tomkp / react-split-pane / 1102

92%

push

travis-ci

Use `getDerivedStateFromProps` more simply (#315)

* Update to React@16.4 and add a test for strict mode

This test is a reproduction for #309 and so is currently failing.

There is some complexity in making it work but it reproduces the problem.

* Don't try and avoid updating state

I'm not sure if this is the best solution for #309, as I am not entirely aware of what this code was trying to do, but it *seemed* like it was trying to avoid touching state too much which doesn't seem super useful as there wasn't any complex calculations involved -- and if there was, memoization would be more useful.

In any case it was triggering problems in strict mode which implies it would have broken in later version of React.

151 of 215 branches covered (70.23%)

2 of 2 new or added lines in 1 file covered. (100.0%)

208 of 228 relevant lines covered (91.23%)

55.14 hits per line