wikimedia / restbase / 712

84%

Pull #166

travis-ci

Cleanup & profiling session

Mostly the results of a profiling session using nodegrind:

 nodegrind server.js -n 0

(in other shell)
 ab -n50000 -c10 \
 http://localhost:7231/en.wikipedia.org/v1/page/Foobar/html/642497713

(hit ctrl-c in nodegrind shell & open kcachegrind on profile)

Changes:
- Convert StatsD into a proper class
- Cache stat names
- Don't create a new bunyan logger for each request, instead handle arg
  merging in the wrapper

In local testing, the combined improvements between [swagger-router]
(https://github.com/wikimedia/swagger-router/pull/16),
[restbase-mod-table-cassandra]
(https://github.com/wikimedia/restbase-mod-table-cassandra/pull/64) and this
patch increase the throughput from around 1700req/s to about 2100req/s.

71 of 71 new or added lines in 4 files covered. (100.0%)

708 of 844 relevant lines covered (83.89%)

57.06 hits per line