GadgetReactor / pyHS100 / 216

80%

push

travis-ci

Fix bug that changed brightness at each HSV update (#124)

* Fix bug that changed brightness at each hsv update

The HSV setter should accept a percentage for the brightness
value but actually assumed the brightness to be in absolute values
between 1 and 255.
This resulted in brightness reductions at each HSV update, in
steps of 100% -> 100/255=39% -> 39/255=15% -> ... (see also
https://github.com/home-assistant/home-assistant/issues/15582,
where I originally reported this bug).

* Modify HSV property to return brightness in percent

Switch from reported brightness values of 1..255 to percentage
values, for consistency with the apidoc and 8761dd8.

* Add checks and tests for the hsv setter

- make sure that new (hue, saturation, brightness) values are
  within their valid ranges (0..255, 0..100, 0..100) and raise
  SmartDeviceException if they are not
- add test function for the hsv setter

82 of 159 branches covered (51.57%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

335 of 502 relevant lines covered (66.73%)

2.0 hits per line