TryGhost / Ghost-Admin / 4187

70%

push

travis-ci

🐛 Fixed ` not triggering code text expansions on German keyboards (Win/macOS only) (#1042)

closes https://github.com/TryGhost/Ghost/issues/9825
- the <code>`</code> key on German keyboard layouts is a dead key and so does not trigger the typical keyboard events our editor relies on
- added custom keyboard event listeners to watch for specific keyboard event sequences triggered by using the dead key + spacebar to insert a <code>`</code>
  - trigger text input handlers when we detect a <code>`</code> insertion
  - Linux unfortunately does not trigger events that can be used to track the sequence so this will not work there although it is easier to set up keyboard layouts without dead keys on Linux
- moved modifier key tracking into global event handlers from ember event handlers
  - reduce confusion from duplicated event handling
  - allows modifier key handlers to fire when keys are pressed without the editor element having focus

1814 of 2912 branches covered (62.29%)

4188 of 5842 relevant lines covered (71.69%)

46.08 hits per line