306
80%
master: 80%

Ran 03 Sep 2018 04:53PM UTC

Jobs 8

Files 146

Run time 10min

Badge

Embed ▾

pending completion

Build # 306

Build Type

Pull #3190

travis-ci

Committed by

web-flow

Commit Message

Stop using custom OrderedDict

OrdredDict is in the standard library for all supported Python versions
(2.7 and 3.5+) and has improvements over the ActiveState recipe version
of OrderedDict we have been using. Switch to importing from collections
instead of getting it from SCons.Util (tests already did this).

At the same time, reorganize the Util.py imports - import Iterable
from collections.abc if possible (it is deprecated to import
it from collections, will stop working in 3.8); try getting the
User{Dict,List,String} from collections if possible - that is, try the
3.x way first.

Signed-off-by: Mats Wichmann <mats@linux.com>

Pull Request Pull Request #3190: Stop using custom OrderedDict

Run Details

12 of 12 new or added lines in 3 files covered. (100.0%)

18380 of 22997 relevant lines covered (79.92%)

4.11 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	96.48	0.02%	src/engine/SCons/Tool/javac.py
2	72.75	0.83%	src/engine/SCons/Util.py

Uncovered Existing Lines

Lines	Coverage	∆	File
1	96.3	0.0%	src/engine/SCons/Scanner/Fortran.py
1	100.0	0.0%	src/engine/SCons/Tool/default.py
1	100.0	0.0%	src/engine/SCons/Tool/pdf.py
1	91.96	0.0%	src/engine/SCons/Executor.py
1	94.32	0.0%	src/engine/SCons/Node/Alias.py
1	97.14	0.0%	src/engine/SCons/Tool/gcc.py
1	95.35	0.0%	src/engine/SCons/Tool/cc.py
1	86.96	0.0%	src/engine/SCons/Variables/ListVariable.py
1	100.0	0.0%	src/engine/SCons/PathList.py
1	100.0	0.0%	src/engine/SCons/Tool/fortran.py
1	100.0	0.0%	src/engine/SCons/Tool/dvi.py
1	97.3	0.0%	src/engine/SCons/Variables/PathVariable.py
1	100.0	0.0%	src/engine/SCons/Tool/cxx.py
1	100.0	0.0%	src/engine/SCons/Scanner/D.py
2	94.59	0.0%	src/engine/SCons/Tool/wix.py
3	96.55	0.0%	src/engine/SCons/Tool/pdflatex.py
3	96.43	0.0%	src/engine/SCons/Tool/latex.py
4	98.19	0.0%	src/engine/SCons/Tool/FortranCommon.py
4	94.12	0.0%	src/engine/SCons/Tool/lex.py
4	100.0	0.0%	src/engine/SCons/Scanner/Dir.py
5	95.65	0.0%	src/engine/SCons/Tool/DCommon.py
5	90.24	0.0%	src/engine/SCons/Node/Python.py
5	98.35	0.0%	src/engine/SCons/Warnings.py
6	90.77	0.0%	src/engine/SCons/Errors.py
6	94.37	0.0%	src/engine/SCons/Memoize.py
7	100.0	0.0%	src/engine/SCons/Tool/f77.py
7	97.01	0.0%	src/engine/SCons/Builder.py
7	27.47	0.0%	src/engine/SCons/Tool/MSCommon/common.py
7	100.0	0.0%	src/engine/SCons/Tool/f95.py
7	100.0	0.0%	src/engine/SCons/Tool/f90.py
8	86.94	0.0%	src/engine/SCons/Tool/JavaCommon.py
8	94.49	0.0%	src/engine/SCons/Subst.py
8	51.03	0.0%	src/engine/SCons/dblite.py
8	96.79	0.0%	src/engine/SCons/Variables/__init__.py
8	85.45	0.0%	src/engine/SCons/Platform/__init__.py
8	100.0	0.0%	src/engine/SCons/Tool/ilink.py
9	50.0	0.0%	src/engine/SCons/Tool/rpm.py
9	65.52	0.0%	src/engine/SCons/Platform/aix.py
10	95.0	0.0%	src/engine/SCons/Tool/pdftex.py
10	100.0	0.0%	src/engine/SCons/Tool/icc.py
10	96.88	0.0%	src/engine/SCons/Tool/filesystem.py
11	79.12	0.0%	src/engine/SCons/Conftest.py
11	100.0	0.0%	src/engine/SCons/Tool/zip.py
14	91.3	0.0%	src/engine/SCons/Tool/g77.py
14	91.3	0.0%	src/engine/SCons/Tool/ifl.py
16	79.31	0.0%	src/engine/SCons/Tool/ifort.py
18	72.75	0.83%	src/engine/SCons/Util.py
19	92.45	0.0%	src/engine/SCons/Tool/dvipdf.py
19	91.67	0.0%	src/engine/SCons/Job.py
20	94.3	0.0%	src/engine/SCons/Script/__init__.py
21	37.5	0.0%	src/engine/SCons/Debug.py
22	88.52	0.0%	src/engine/SCons/Tool/yacc.py
29	98.84	0.0%	src/engine/SCons/Scanner/LaTeX.py
30	22.48	0.0%	src/engine/SCons/Tool/intelc.py
30	43.11	0.0%	src/engine/SCons/Tool/MSCommon/sdk.py
35	84.97	0.0%	src/engine/SCons/CacheDir.py
35	91.23	0.0%	src/engine/SCons/Tool/rmic.py
37	96.62	0.0%	src/engine/SCons/Action.py
45	91.03	0.23%	src/engine/SCons/Taskmaster.py
46	57.85	0.0%	src/engine/SCons/Tool/swig.py
47	95.02	0.0%	src/engine/SCons/SConf.py
52	94.81	0.0%	src/engine/SCons/Tool/javah.py
56	90.63	0.0%	src/engine/SCons/SConsign.py
65	93.92	0.0%	src/engine/SCons/Environment.py
70	82.32	0.0%	src/engine/SCons/Tool/link.py
73	88.29	0.0%	src/engine/SCons/Tool/jar.py
75	92.72	0.0%	src/engine/SCons/Defaults.py
78	87.19	0.0%	src/engine/SCons/Script/SConsOptions.py
80	96.48	0.02%	src/engine/SCons/Tool/javac.py
80	95.47	0.0%	src/engine/SCons/Node/__init__.py
97	83.22	0.0%	src/engine/SCons/Script/Interactive.py
109	86.09	0.0%	src/engine/SCons/Tool/install.py
115	74.93	0.0%	src/engine/SCons/Tool/__init__.py
120	92.73	0.0%	src/engine/SCons/Node/FS.py
128	91.71	0.0%	src/engine/SCons/Script/SConscript.py
136	62.03	0.0%	src/engine/SCons/Tool/MSCommon/vc.py
313	93.22	0.0%	src/engine/SCons/Script/Main.py
322	85.41	0.0%	src/engine/SCons/Tool/tex.py
738	73.92	0.0%	src/engine/SCons/Tool/msvs.py

Jobs

ID	Job ID	Ran	Files	Coverage
6	306.6 (BUILD_JOB_NUM=1)	03 Sep 2018 04:53PM UTC	121	65.14	Travis Job 306.6
7	306.7 (BUILD_JOB_NUM=2)	03 Sep 2018 04:54PM UTC	114	61.25	Travis Job 306.7
8	306.8 (BUILD_JOB_NUM=3)	03 Sep 2018 04:54PM UTC	114	56.08	Travis Job 306.8
9	306.9 (BUILD_JOB_NUM=4)	03 Sep 2018 04:55PM UTC	123	58.12	Travis Job 306.9
10	306.10 (BUILD_JOB_NUM=5)	03 Sep 2018 04:55PM UTC	116	59.29	Travis Job 306.10
11	306.11 (BUILD_JOB_NUM=6)	03 Sep 2018 05:01PM UTC	117	56.8	Travis Job 306.11
12	306.12 (BUILD_JOB_NUM=7)	03 Sep 2018 05:03PM UTC	183	59.37	Travis Job 306.12
13	306.13 (BUILD_JOB_NUM=8)	03 Sep 2018 05:01PM UTC	114	58.82	Travis Job 306.13

SCons / scons / 306
80%
master: 80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 306

SCons / scons / 306 80% master: 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 306

SCons / scons / 306
80%
master: 80%

README BADGES
x