ndlib / sipity / 742

100%

master: 98%

push

travis-ci

Renaming pid_minter to default_pid_minter

@banurekha noticed this behavior. In the previous implementation
I was hoping the named :pid_minter parameter, if nil would set the
named parameter to the module's `pid_minter` method. However it was
setting the named parameter's value to itself, thus
`attach_file_to(work: work, file: file, user: user)` would result in
the pid_minter parameter being nil.

This clarifies the behavior, and while I would prefer a pid_minter
method, I will settle for default_pid_minter.

Good catch @banurekha

Also, appeasing Rubocop's identification that the user parameter was
not needed. I know we need it, but for now, I'll settle one what we
have.

3 of 3 new or added lines in 1 file covered. (100.0%)

2377 of 2377 relevant lines covered (100.0%)

6.32 hits per line