enova / sidekiq-rate-limiter / 62

91%

master: 100%

Pull #29

travis-ci

Make limit check and additions an atomic operation

Due to the fact that checking whether the limit is exceeded and adding a new item to the list are different operations, if two sidekiq jobs are performed at the same time and check for the limit at the same time, both can be returned true, and proceed with executing the work.

The addition of a semaphore for the check & add to limit operations ensures that it's only done by one job at the time, and fixes the race condition.

7 of 7 new or added lines in 1 file covered. (100.0%)

66 of 67 relevant lines covered (98.51%)

17.73 hits per line