stripe / stripe-go / 3312
83%
master: 66%

LAST BUILD BRANCH: latest-codegen-beta
DEFAULT BRANCH: master
Ran
Jobs 5
Files 133
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.373% (-1.3%) from 84.66%
3312

Pull #672

travis-ci

web-flow 
Attempt to fix racy test

We're currently seeing the occasional build failure in CI that looks like this:

```
$ make
go test -race ./...
--- FAIL: TestContext_Cancel (0.00s)
    assertions.go:256:
            Error Trace:    stripe_test.go:67
            Error:          Expect "{"status":401,"message":"Please authenticate by specifying an `Authorization` header with any valid looking testmode secret API key. For example, `Authorization: Bearer sk_test_123`. Authorization was 'Bearer '.","type":"invalid_request_error"}" to match "(request canceled|context canceled\z)"
            Test:           TestContext_Cancel
2018/08/22 20:05:38 Requesting POST 127.0.0.1:35137/v1/hello
2018/08/22 20:05:38 Request completed in 1.519412ms (retry: 0)
2018/08/22 20:05:38 Request failed with: {"error":"Conflict (this should be retried)."} (error: <nil>)
2018/08/22 20:05:38 Initiating retry 1 for request POST 127.0.0.1:35137/v1/hello after sleeping 0s
2018/08/22 20:05:38 Request completed in 948.533µs (retry: 1)
2018/08/22 20:05:38 Response: {"message":"Hello, client."}
FAIL
FAIL    github.com/stripe/stripe-go 0.153s
```

The test seems to be designed to avoid a race by making sure to cancel its
cancellable context even before executing the request, which you'd think
prevent the request from ever happening, but which apparently does not because
you can see the error message above that's being returned from stripe-mock.

This did seem to be non-racy for a very long time so my guess is that Go's
HTTP/2 implementation changed this behavior slightly in that it's now possible
for a request to start executing even if the attached context is already
cancelled. The test became unreliable roughly around the same time we switched
the test suite over to use HTTP/2.

Here I try to "fix" the problem by making sure the request takes longer.
Because we're not passing a key and hitting a non-endpoint right now,
stripe-mock is able to fall through very quickly because it notices the mi... (continued)
Pull Request #672: Attempt to fix racy test

2778 of 3332 relevant lines covered (83.37%)

142.37 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3312.1 102
84.66
 Travis Job 3312.1
2 3312.2 102
84.66
 Travis Job 3312.2
3 3312.3 102
84.66
 Travis Job 3312.3
4 3312.4 102
84.66
 Travis Job 3312.4
5 3312.5 102
84.66
 Travis Job 3312.5
Source Files on build 3312