• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

apache / bookkeeper / 193
72%

Build:
DEFAULT BRANCH: master
Ran 28 Aug 2018 03:12PM UTC
Jobs 1
Files 437
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
193

push

jenkins

Sijie Guo
ISSUE #1623: ReadOnlyLedgerHandle: don't schedule monitorPendingAddOps()

The LedgerHandle constructor schedules an addEntryQuorumTimeout check
with the bk client scheduler. However, the only place this callback is
canceled is in the closeAsync (the one which returns a future, not to be
confused with asyncClose) method. asyncClose and close() both leak this
callback. Moreover, ReadOnlyLedgerHandle invokes the LedgerHandle
constructor and so also creates this callback, but it overrides close()
and asyncClose() without passing them through.

ReadOnlyLedgerHandle already overrides
initializeExplicitLacFlushPolicy() to avoid write specific state.  This
patch generalizes that hack to initializeWriteHandleState() and the
cleanup to tearDownWriteHandleState().  tearDownWriteHandleState() is
moved into doAsyncClose(), which appears to be called for closes in
general.

(rev cguttapalem)
(bug W-5362724)
Signed-off-by: Samuel Just <sjustsalesforce.com>

Author: Samuel Just <sjust@salesforce.com>

Reviewers: Ivan Kelly <ivank@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1624 from athanatos/forupstream/wip-1623, closes #1623

11 of 11 new or added lines in 1 file covered. (100.0%)

24851 of 34301 relevant lines covered (72.45%)

0.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 193.1 28 Aug 2018 03:12PM UTC 0
72.45
Source Files on build 193
Detailed source file information is not available for this build.
  • Back to Repo
  • Jenkins Build #193
  • 9279dcc1 on github
  • Prev Build on master (#192)
  • Next Build on master (#194)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc