tarantool / tarantool / 13717

83%

master: 87%

push

travis-ci

vinyl: fix fiber leak in worker thread

We join a fiber that executes a dump/compaction task only at exit
while we mark all fibers as joinable. As a result, fibers leak, which
eventually leads to a crash:

  src/lib/small/small/slab_arena.c:58: munmap_checked: Assertion `false' failed.

Here's the stack trace:

  munmap_checked
  mmap_checked
  slab_map
  slab_get_with_order
  mempool_alloc
  fiber_new_ex
  fiber_new
  cord_costart_thread_func
  cord_thread_func
  start_thread
  clone

Let's fix this issue by marking a fiber as joinable only at exit, before
joining it. The fiber is guaranteed to be alive at that time, because it
clears vy_worker::task before returning, while we join it only if
vy_worker::task is not NULL.

Fixes commit 43b4342d0b9b ("vinyl: fix worker crash at exit").

2 of 2 new or added lines in 1 file covered. (100.0%)

40512 of 49430 relevant lines covered (81.96%)

862418.05 hits per line