aragon / aragonOS / 1706

82%

push

travis-ci

Update to solc 0.4.24 (#383)

There's a ton of changes in this PR, the main goals were updating to the new compiler version and doing some clean up to reduce the number of compiler warnings (close #385):

- Bumps truffle dependency to a more recent one that comes with Solidity 0.4.24.
- Fixes almost all compiler warnings we care about
- Changes all constructors to the new `constructor()` syntax
- Adds `emit` keyword to all events
- Passing anything other than a bytes array to `keccak256()` is now deprecated, a manual `abi.encodePacked(...)` has been added when calculating all hashes.
- 💥Removes all the fun [custom abi encoding](https://github.com/aragon/aragonOS/pull/383/files#diff-6d2e88efa27690b63879e31ffb310725L9) in favor of using `abi.encodeWithSelector` 
- Update solidity-coverage to `0.5.7`. Solidity mocks and tests had to be moved to `contracts/tests` so they could be instrumented correctly (see https://github.com/sc-forks/solidity-coverage/issues/182) and not interfere with the ABI-swapping.

166 of 172 branches covered (96.51%)

Branch coverage included in aggregate %.

67 of 67 new or added lines in 17 files covered. (100.0%)

470 of 470 relevant lines covered (100.0%)

424.6 hits per line