9355
33%

Ran 24 Aug 2018 06:00AM UTC

Jobs 1

Files 431

Run time 32s

Badge

Embed ▾

pending completion

Build # 9355

Build Type

push

travis-ci

Committed by

kevingranade

Commit Message

Fix crash with no audio device (#25045)

* Fix crash with no audio device

If the game was compiled with SOUND=1 but the system doesn't actually
have an audio device to use, it crashes to desktop as it keeps trying to
setup and use a non-existent audio device, even if you have
SOUND_ENABLED set to `false` in options.json.

This fixes the issue by adding some checks to make sure sound is enabled
and didn't fail to init when we go playing with audio.

This attempts to treat a corner case where if you start the game with no
audio devices, but then enable one, then try disabling/enabling audio in
the options menu, we should theoretically get sound to work if we try to
re-init the audio device.  In my local testing, sound appeared to still
not work after enabling the audio device after toggling the option, but
there might be systems where this does actually work/or there's
something I missed that can fix that corner case.

In any case this fixes the crash to desktop.

Fixes #24142

SUMMARY: Bugfixes "Fix crash with no audio device"

* Make volume const in check_sound

Run Details

26472 of 108687 relevant lines covered (24.36%)

120473.04 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	9355.2 (COMPILER=g++-4.8 CODE_COVERAGE=true)	24 Aug 2018 06:00AM UTC	0	24.36	Travis Job 9355.2

Source Files on build 9355

Detailed source file information is not available for this build.

CleverRaven / Cataclysm-DDA / 9355
33%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9355

CleverRaven / Cataclysm-DDA / 9355 33%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 9355

CleverRaven / Cataclysm-DDA / 9355
33%

README BADGES
x