pydata / xarray / 5750

96%

cron

travis-ci

Fix maybe_promote (#1953)

* Fix maybe_promote

With tests for every possible dtype:

(numpy docs say `biufcmMOSUV` only)

```
for letter in string.ascii_letters:
    try:
        print(letter, np.dtype(letter))
    except TypeError as exc:
        pass
```

* Check issubdtype of floating before timedelta64

In order to hit this branch more often

* Improve maybe_promote test

6 of 6 new or added lines in 2 files covered. (100.0%)

24939 of 25727 relevant lines covered (96.94%)

8.17 hits per line