8517
74%
master: 37%

Ran 23 Aug 2018 07:27PM UTC

Jobs 1

Files 269

Run time 34s

Badge

Embed ▾

pending completion

Build # 8517

Build Type

Pull #2909

travis-ci

Committed by

web-flow

Commit Message

schannel: client certificate store opening fix

1) Using CERT_STORE_OPEN_EXISTING_FLAG ( or CERT_STORE_READONLY_FLAG )
while opening certificate store would be sufficient in this scenario and
less-demanding in sense of required user credentials ( for example,
IIS_IUSRS will get "Access Denied" 0x05 error for existing CertOpenStore
call without any of flags mentioned above ),

2) as 'cert_store_name' is a DWORD, attempt to format its value like a
string ( in "Failed to open cert store" error message ) will throw null
pointer exception

3) adding GetLastError(), in my opinion, will make error message more
useful.

Bug: https://curl.haxx.se/mail/lib-2018-08/0198.html

Pull Request Pull Request #2909: schannel: client certificate store opening fix

Run Details

20738 of 27940 relevant lines covered (74.22%)

590158.44 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	79.01	-0.08%	lib/multi.c
1	93.16	-0.85%	lib/base64.c
1	86.67	-3.33%	lib/hostasyn.c
1	85.86	-0.25%	lib/easy.c
1	82.2	-0.05%	lib/ftp.c
2	86.31	-0.32%	lib/smtp.c
13	68.47	-11.71%	lib/splay.c

Jobs

ID	Job ID	Ran	Files	Coverage
21	8517.21 (T=coverage)	23 Aug 2018 07:27PM UTC	269	74.22	Travis Job 8517.21

curl / curl / 8517
74%
master: 37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8517

curl / curl / 8517 74% master: 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 8517

curl / curl / 8517
74%
master: 37%

README BADGES
x