5457

Ran 19 Aug 2018 05:16AM UTC

Jobs 2

Files 99

Run time 19s

Badge

Embed ▾

pending completion

Build # 5457

Build Type

push

travis-ci

Committed by

buger

Commit Message

prevent read to Redis from OrganizationMonitor MW (#1787)

While experimenting with changes to eliminate extra I/O to redis I saw some good improvements so decided to make PR for that. These changes include:

- in case org limiter was enabled for spec but org session wasn't created - don't read from Redis within every single API request
- if we know that spec has org session - use in-app cache for org sessions 1st then fall back to Redis read
- when org session is created - set spec's flag to identify that org rate limiter should start using it
- when org session is deleted - set spec's flag to identify that org rate limiter should stop using it 

I think 1st point covers some special/corner case, however it still needs to be addressed imho. 

benchcmp vs. current master:
```
benchmark                                                                                                   old ns/op     new ns/op     delta
BenchmarkURLReplacer-8                                                                                      1884          1892          +0.42%
BenchmarkTagHeaders-8                                                                                       944           949           +0.53%
BenchmarkDefaultVersion-8                                                                                   1029116       1019975       -0.89%
BenchmarkGetVersionFromRequest/Header_location-8                                                            526065        495921        -5.73%
BenchmarkGetVersionFromRequest/URL_param_location-8                                                         493047        535067        +8.52%
BenchmarkGetVersionFromRequest/URL_location-8                                                               459850        473349        +2.94%
BenchmarkApiReload-8                                                                                        3571882       3483883       -2.46%
BenchmarkValueExtractor/HeaderSource... (continued)

Run Details

9506 of 15769 relevant lines covered (60.28%)

1.33 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5457.1 (LATEST_GO=true)	19 Aug 2018 05:16AM UTC	0	59.67	Travis Job 5457.1
2	5457.2 (LATEST_GO=true)	19 Aug 2018 05:16AM UTC	0	60.3	Travis Job 5457.2

Source Files on build 5457

Detailed source file information is not available for this build.

TykTechnologies / tyk / 5457

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5457

TykTechnologies / tyk / 5457

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5457

README BADGES
x