SCons / scons / 280

80%

master: 80%

Pull #3177

travis-ci

Redo fix for file closing in SCons.Action._subproc

When the _subproc wrapper is called, a keyword dictionary is used to
hold open file objects if any were indicated as being redirected to
os.devull.  These objects just go missing when SCons.Action._subproc
is done.  A previous iteration registered the close method of the object
with atexit, which made Python 3 happy the open file resources were not
leaking, but has some unexpected side effects. Apparently Action cannot
import either atexit or the SCons equivalent, SCons.exitfuncs without
triggering these effects.

As an alternative, close the objects in the parent's kw dictionary that
have close methods after the subprocess.Popen object has been created.

Signed-off-by: Mats Wichmann <mats@linux.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

19940 of 24419 relevant lines covered (81.66%)

3.92 hits per line