215
58%
master: 92%

Ran 14 Aug 2018 10:14PM UTC

Jobs 2

Files 35

Run time 84min

Badge

Embed ▾

pending completion

Build # 215

Build Type

Pull #57

travis-ci

Committed by

web-flow

Commit Message

Start cleaning up bundle_spec

Start getting rid of `@instance_variables` in spec.

Treat `bundle_setup` more like a factory, less like a side-effecty
pre-condition.  End goal: git rid of `@b`, which is effectively the
subject.

Use more `let` statements, shrink `before` blocks.  Get rid of global
`before(:all)` block completely.  This appears to have been an attempt
to optimize reading of YAML files off disk (i.e. read them all once
beforehand, cache the results). This spec file takes `0.23589 seconds`
to run. Lesson: don't bother trying to outsmart disk caching.

Use more normal description style of `#method_name`, not
`method_name()`.

Don't use one symbol/string name to refer to the yaml file in tests and
another to actually name the file.  Use the same name. That gets rid of
the `@yaml_filenames`.

Less loops inside `it` blocks. Use `all` matcher for the same
expectation on every element of an array, for example.

Pull Request Pull Request #57: Start cleaning up bundle_spec

Run Details

1264 of 2174 relevant lines covered (58.14%)

40.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	215.1 (2.3.7)	14 Aug 2018 10:15PM UTC	0	58.14	Travis Job 215.1
2	215.2 (2.4.4)	14 Aug 2018 10:14PM UTC	0	52.67	Travis Job 215.2

Source Files on build 215

Detailed source file information is not available for this build.

sul-dlss / pre-assembly / 215
58%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 215

sul-dlss / pre-assembly / 215 58% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 215

sul-dlss / pre-assembly / 215
58%
master: 92%

README BADGES
x