salesforce / refocus-collector / 232

94%

push

travis-ci

Handle heartbeat errors by pausing/resuming generator repeaters,… (#143)

* Handle heartbeat errors by pausing/resuming generator repeaters, remove subject from repeater validation

- src/heartbeat/listener.js
  - move error handling to separate fn for readability
  - wrap all the code in the main listener fn and the onError fn in try/catch so that errors don't bubble up and get caught by heartbeat.js itself, which should only be catching errors from the heartbeat POST request
  - if the heartbeat POST request returns an error, pause all the generator repeaters and set a new local var pausedAfterHeartbeatError to true; once we get a good heartbeat response, if pausedAfterHeartbeatError is true, resume the generator repeaters
  - sanitize config debug using attributesToSanitize instead of hard-coded array of attribute names

- src/repeater/repeater.js
  - update validateDefinition - no longer needs to check the subjects attribute - just check for duplicate name being tracked
  - update pauseGenerators/resumeGenerators - no return value needed (was only there for tests, no longer needed)
  - track names of paused generators - make it easier to test
  - add comments about errors being thrown
  - minor style changes and cleanup

- test/heartbeat/listener.js
  - confirm that generator repeaters are paused after a heartbeat error and resumed after next good heartbeat

- test/repeater/repeater.js
  - update tests to check repeater.paused

Other Changes

- src/commands/start.js
  - minor change to use the new simplified sanitize fn

- src/config/config.js
  - export the names of the attributes to sanitize when sanitizing config data (instead of hard-coding them everywhere we actually debug the config)

- src/heartbeat/heartbeat.js
  - minor style changes and cleanup
  - sanitize config debug using attributesToSanitize instead of hard-coded array of attribute names

- src/heartbeat/utils.js
  - add comments about errors being ... (continued)

223 of 254 branches covered (87.8%)

Branch coverage included in aggregate %.

647 of 668 relevant lines covered (96.86%)

70.06 hits per line