se-edu / addressbook-level4 / 4656

94%

push

travis-ci

XmlSerializableAddressBook: check for duplicate person(s)

When the address book XML file happens to contain duplicate person(s),
XmlSerializableAddressBook#toModelType() will throw an unchecked
DuplicatePersonException instead of the checked IllegalValueException
which it promises to throw.

This is because XmlSerializableAddressBook#toModelType() relied on
AddressBook#addPerson(Person) throwing DuplicatePersonException when a
duplicate person is encountered. Since DuplicatePersonException
inherited from DuplicateDataException, which in turn inherited from
IllegalValueException, this gave rise to the expected behavior.

However, 6817bd35 (model: make DuplicatePersonException a
RuntimeException, 2018-08-07) made DuplicatePersonException inherit from
RuntimeException. Since this commit, all callers of
AddressBook#addPerson(Person) are expected to perform the duplicate
person check using AddressBook#hasPerson(Person). Yet,
XmlSerializableAddressBook#toModelType() was not updated.

Fix this by teaching XmlSerializableAddressBook#toModelType() to
explicitly check for duplicate persons using
AddressBook#hasPerson(Person). Add a test to prevent future regressions.

4 of 4 new or added lines in 1 file covered. (100.0%)

1433 of 1544 relevant lines covered (92.81%)

0.93 hits per line