96
84%
master: 81%

Ran 10 Aug 2018 01:55PM UTC

Jobs 1

Files 9

Run time 2s

Badge

Embed ▾

pending completion

Build # 96

Build Type

Pull #25

travis-ci

Committed by

web-flow

Commit Message

Tests for the IPv6 fix.

It has to be noted that the IPv6 fix invalidates the run-time address check previously performed via `rust-url`'s `Url::domain()` method.  This means that invalid host names (other than empty ones) won't be detected at this point any longer, but will cause any requests to fail later on.  I think this is acceptable and common practice.  In any case, as the implicit validation done by the aformented `domain()` method fails for IPv6 addresses, it cannot be kept without limiting the project's general utility.

In the course of adding a test case for the IPv6 handling, I noticed that `test_get_error_url()` in `client.rs` will effectively always fail: even if the URL did parse, you'd get an error due to the CoAP server in question not being reachable (unless there *happens* to be one running on that endpoint).  Consequently, I've renamed and reworked the function to test `parse_coap_url()` explicitly and directly.  One of the assertions depended on recognizing an invalid host name (which now doesn't happen any longer, see above), so I replaced this with other variants of overall bad URLs (empty host, invalid port).

Pull Request Pull Request #25: Fix: Make URLs with IPv6 addresses usable

Run Details

1226 of 1456 relevant lines covered (84.2%)

0.84 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	80.37	-0.47%	server.rs
1	84.16	-0.38%	observer.rs
2	96.3	-1.23%	message/header.rs
24	79.25	0.25%	client.rs

Jobs

ID	Job ID	Ran	Files	Coverage
3	96.3	10 Aug 2018 01:55PM UTC	9	84.2	Travis Job 96.3

Covertness / coap-rs / 96
84%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 96

Covertness / coap-rs / 96 84% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 96

Covertness / coap-rs / 96
84%
master: 81%

README BADGES
x