se-edu / addressbook-level4 / 4644

93%

master: 94%

Pull #898

travis-ci

Command: combine setData(...) and execute() together

To execute a command, (e.g. AddCommand), we need to

  1. Construct it:

         AddCommand addCommand = new AddCommand(person);

  2. Bind the model and command history to it:

         addCommand.setData(model, commandHistory);

  3. And then execute it:

         addCommand.execute();

However, there is no reason why step (2) and step (3) must be separate,
when it could just be:

    addCommand.execute(model, commandHistory);

In fact, it causes more trouble:

  * Since the model and commandHistory are stored as protected fields in
    the Command base class, many commands forget to handle them
    appropriately. For example, all commands don't consider the model
    and commandHistory in their `#equals(...)` methods, even though
    these fields are part of their state.

  * Many command tests need to introduce a helper `prepareCommand(...)`
    method to streamline the command "setData and execute" process.

So, let's fix this by combining Command#setData(...) and
Command#execute() together. We can then simplify all the command tests
by removing their `prepareCommand(...)` helper methods.

17 of 17 new or added lines in 8 files covered. (100.0%)

1430 of 1541 relevant lines covered (92.8%)

0.93 hits per line