thibaultcha / lua-cassandra / 1061
94%
master: 93%

LAST BUILD BRANCH: 1.5.1
DEFAULT BRANCH: master
Ran
Jobs 7
Files 14
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1061

Pull #118

travis-ci

web-flow 
fix(cluster) use 'listen_address' for contact point in refresh()

Previously, using `coordinator.host` to add the contact point to the
LB policy means that if the user specified a hostname, then it would be
used to index this node instead of the IP address. Nothing harmful in
that except some inconsistent log messages (sometimes an IP address
shows up, other times a hostname).

Problem
-------

An issue arises however when:

1. Several Cluster instances call `:refresh()` on the same C* cluster
2. DNS round-robin is in effect for the contact point hostnames

Let's consider clusterA and clusterB, both instances of the Cluster
module. Let's also consider the following C* cluster:

    10.16.0.1 node1
    10.16.0.2 node2

And the following DNS record:

    cassandra.default.svc.cluster.local. 30    IN A    10.16.0.1
    cassandra.default.svc.cluster.local. 30    IN A    10.16.0.2

First, clusterA calls `refresh()`, with `contact_points = { "cassandra"
}`, and as a result inserts the following topology in the cluster's shm:

    cassandra:[peer info]
    10.16.0.2:[peer info]

Its LB policy now has 2 entries: `cassandra` and `10.16.0.2`.

Then, clusterB calls `refresh()` as well, with the same `contact_points`
option, and as a result first purges the cluster's shm content, before
inserting the following:

    10.16.0.1:[peer info]
    cassandra:[peer info]

Note that because of the round-robin DNS resolution, `cassandra` pointed
to `10.16.0.2` this time.

Now, when clusterA will invoke its LB policy to elect a peer for a given
query, it will eventually look for `10.16.0.2`. However, such an entry
does not exist in the cluster's shm anymore. Therefore, the following
error is returned:

    no host details for 10.16.0.2

Proposed solution
-----------------

By replacing the cache key of the peer's info in the shm from the
specified `contact_point` value (which is the user's input), to the
`listen_address` column of the `system.local` table, do not store host... (continued)
Pull Request #118: fix(cluster) use 'listen_address' for contact point in refresh()

1542 of 1634 relevant lines covered (94.37%)

4016.01 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
96.61
 0.0% ./lib/cassandra/cql.lua
8
99.43
 0.0% ./lib/cassandra/init.lua
Jobs
ID Job ID Ran Files Coverage
1 1061.1 (LUA="lua 5.1") 3
96.66
 Travis Job 1061.1
2 1061.2 (LUA="lua 5.2") 3
96.66
 Travis Job 1061.2
3 1061.3 (LUA="luajit 2.0") 3
96.32
 Travis Job 1061.3
4 1061.4 (LUA="luajit 2.1") 3
96.32
 Travis Job 1061.4
5 1061.5 (OPENRESTY_TESTS=true CASSANDRA=3.9) 14
75.81
 Travis Job 1061.5
6 1061.6 (OPENRESTY_TESTS=true CASSANDRA=2.2.8) 14
76.29
 Travis Job 1061.6
7 1061.7 (OPENRESTY_TESTS=true CASSANDRA=2.1.16) 14
75.76
 Travis Job 1061.7
Source Files on build 1061