xapi-project / nbd / 350

75%

master: 65%

Pull #131

travis-ci

CP-29049: Fix list and abort behaviour and expand protocol tests

Various fixes to make the client and server conform more to the NBD
protocol:
* Ensure Client.list terminates the option haggling by sending an abort.
  This change should not cause problems, as currently we don't seem to
  use Client.list anywhere.
* Fix the server's response to NBD_OPT_LIST - previously it did not send
  the lenghts to the client correctly, and therefore qemu-img and
  nbd-client could not list the exports.
* Check that the lengths the export names in the optional ~offer param
  passed to Server.connect are below the maximum limit allowed by the NBD
  protocol.
* Ensure the server responds to an abort with an ack. This change
  shouldn't cause issues either, because we gracefully handle the case
  without failing where the client disconnects without waiting for the
  ack.
* Clean up existing protocol unit tests, add more logging, and more
  tests for these corner cases.
* Add a new client<->server interaction test to check that NBD_OPT_LIST
  is implemented properly in both.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>

27 of 27 new or added lines in 2 files covered. (100.0%)

418 of 560 relevant lines covered (74.64%)

3396.83 hits per line