shoes / shoes4 / 2760

90%

master: %

Build Type

Pull #1244

travis-ci

Committed by Wayne Vucenic

Commit Message

Fix several calculator issues

In any physical, real-world calculator I can recall using, if I wanted to compute 2+2 and 3+3 I would click the following buttons:

2 + 2 = 3 + 3 =

But if I do that in this program,

2 + 2 =

shows "4", as expected, but then clicking 3 changes the display to "43".

I appreciate that the sample is intended as an example of using Shoes, not an example of how to write calculator logic.  But this problem makes it hard to actually use the calculator.

Another fix is that on most calculators, doing:

1 + 2 + 3 + 4 + 5 + 6 + 7 + 8 + 9 =

shows the running total every time + is clicked.  This program did not display any result until = was clicked.

Renamed several instance variable to be more precise.

Corrected 4 RuboCop issues.

Pull Request Pull Request #1244: Fix several issues in simple-calc-2 sample

Run Details

403 of 552 branches covered (73.01%)

1966 of 2179 relevant lines covered (90.22%)

73.96 hits per line