2094

Ran 30 Jul 2018 12:19AM UTC

Jobs 3

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 2094

Build Type

push

travis-ci

Committed by

wesm

Commit Message

PARQUET-1360: Use conforming API style, variable names in WriteFileMetaData functions

Per comments in PARQUET-1348. I also upgraded clang-format to 6.0 here so pardon the diff noise from that.

To summarize the style points:

* Don't pass `const std:shared_ptr<T>&` if `const T&` will do
* Don't pass `const std::shared_ptr<T>&` if `T*` will do
* I prefer to only use class static function members for alternate constructors
* Out arguments after in arguments
* `lower_with_underscores` for variable names

Author: Wes McKinney <wesm+git@apache.org>

Closes #482 from wesm/PARQUET-1360 and squashes the following commits:

375a442 [Wes McKinney] API conformity and changes per review comments in ARROW-1348

Run Details

Jobs

ID	Job ID	Ran
1	2094.1	30 Jul 2018 12:19AM UTC	Travis Job 2094.1
2	2094.2	30 Jul 2018 12:21AM UTC	Travis Job 2094.2
3	2094.3	30 Jul 2018 12:22AM UTC	Travis Job 2094.3

Source Files on build 2094

Detailed source file information is not available for this build.

apache / parquet-cpp / 2094

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2094

apache / parquet-cpp / 2094

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2094

README BADGES
x