pvlib / pvlib-python / 1309

96%

push

travis-ci

BUG: fix klucher nan output for numpy (#509)

* BUG: fix klucher nan output for numpy

* fixes #508
* use `F = np.where(np.isnan(F), 0, F) to only replace `nan` with zero
* previously if numpy array with nan, then entire array was zeroed so output differed from pandas series input

* update klucker tests

* the original test had the bug in it, because floats don't have `fillna` attribute, **but** that doesn't mean that the value was `NaN`!
* instead of hard-coding the expected value, what we really expect is that it should produce the same value as the pandas series result
* also compare the pandas series result to a numpy array of the same

* DOC: MAINT: update what's new

9 of 9 new or added lines in 2 files covered. (100.0%)

5522 of 6047 relevant lines covered (91.32%)

4.26 hits per line