source-academy / cadet-frontend / 466

30%

push

travis-ci

Allow external libraries to be shared (#235)

* Rename parseLib -> parseChapter

* Update test file

* Change container to pass in correct props

- externalLibrary prop
- correct dispatch

* Add placeholder for parsing external library

* Fix import order

* Add failsafe for illegal library name

* Scaffold parsing function

And moved checking to component instead

* Fix "resetWebGl is not a function" error

This is solved by accessing the function getReadyWebGLForCanvas right
when we need it.

* Make Application a Component

The call to parsePlayground, that causes state changes, should be done
after mounting

* Change playgroundExternalSelect definition

There is no need for extra parameters that go unused

* Add handlePlaygroundExternalSelect to Application

* Refactor handleExternalSelect usage

* Change handleExternalSelect usage in container

* Add delay to allow loading of library .js files

To be replaced with a race condition (worst case, 5 seconds and fail
message)

* Format files

* Change chapterSelect definition

* Change handleChapterSelect in Playground

* Format file

* Update Application test

* Add condition and comment for delay

* Format file

* Add function to check getReadyWebGLForCanvas

* Format files

* Fix rebase errors

* Add ENSURE_LIBRARIES_LOADED action and saga

The action is to be used by Application, before clear context is called.
This is when the libraries might not be loaded before clear context is
called. The checkWebGLAvailable function has also been abstracted to
be used by both ENSURE_LIBRARIES_LOADED and CLEAR_CONTEXT

* Use ensureLibrariesLoaded in component

* Update comments

* Remove all() usage

and update the docs a bit more

* Format saga

102 of 850 branches covered (12.0%)

Branch coverage included in aggregate %.

776 of 2606 relevant lines covered (29.78%)

1.28 hits per line