4584
94%

Ran 25 Jul 2018 12:09PM UTC

Jobs 1

Files 91

Run time 6s

Badge

Embed ▾

pending completion

Build # 4584

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

[#855] Refactor PersonBuilder constructor to use TypicalPersons as argument (#889)

When creating a Person for testing, some tests specify almost all of
the fields of an existing TypicalPerson, with only a slight variation
in one or two fields. For example, the code below builds on top of
TypicalPerson#AMY with only changes to address and tags:

    toAdd = new PersonBuilder().withName(VALID_NAME_AMY).withPhone(VALID_PHONE_AMY)
            .withEmail(VALID_EMAIL_AMY).withAddress(VALID_ADDRESS_BOB)
            .withTags(VALID_TAG_FRIEND).build();

This is long-winded and unnecessary, as PersonBuilder allows us to start
from a ready-made Person, and modify as necessary. For example, the code
above can be refactored to:

    toAdd = new PersonBuilder(AMY).withAddress(VALID_ADDRESS_BOB).build();

Let's refactor the calls to PersonBuilder to make them more concise.

Run Details

1431 of 1552 relevant lines covered (92.2%)

0.92 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	4584.1	25 Jul 2018 12:09PM UTC	0	92.2	Travis Job 4584.1

Source Files on build 4584

Detailed source file information is not available for this build.

se-edu / addressbook-level4 / 4584
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4584

se-edu / addressbook-level4 / 4584 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4584

se-edu / addressbook-level4 / 4584
94%

README BADGES
x