PyCQA / pylint-django / 452

0%

push

travis-ci

Be more strict when infering ForeignKey models specified as string

The failing `func_noerror_foreignkeys` was caused by pylint_django
trying to infer a ForeignKey('Author') field by looking at the
astroid cache. In this case there was an Author model already
defined in `func_noerror_duplicate_except_doesnotexist` which
was inferred and of course this model didn't have the `author_name`
field hence we got a no-member error.

This commit tries to restrict where we load these models from
and also takes into account the quirk that Django allows specifying
'appname.Model' instead of 'path.to.python.module.models.Model'.

9 of 9 new or added lines in 1 file covered. (100.0%)

570 of 655 relevant lines covered (87.02%)

6.08 hits per line