• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

share / sharedb / 792
97%
master: 97%

Build:
Build:
LAST BUILD BRANCH: dependabot/github_actions/actions/checkout-6
DEFAULT BRANCH: master
Ran 19 Jul 2018 02:56PM UTC
Jobs 5
Files 19
Run time 43s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
792

Pull #227

travis-ci

web-flow
Fix flaky maxSubmitRetries test

This is a slightly speculative fix for a test that fails intermittently
on `sharedb-mongo`. I believe these intermittent failures are due to a
race condition in a concurrency test.

The test works by attempting to fire two commits off at the same time,
and hoping that one of them is committed just before the other, so that
a `SubmitRequest.retry` is triggered whilst the `maxSubmitRetries` is
set to `0`, resulting in an error that is expected.

However, I believe it's possible for these commits to (in some cases)
happen sequentially rather than concurrently, and fail to error.

This change attempts to force them into this retry condition by:

  - Catching both ops in the `commit` middleware, _just_ before they're
    about to be committed (and hit a `retry` if applicable)
  - Waiting until both ops have reached this state
  - Triggering the first op's `commit`
  - Then in the callback of that op, triggering the second op's `commit`
  - The second op should now find that the first op has beaten it to
    committing, and trigger a `retry`
Pull Request #227: Fix flaky maxSubmitRetries test

1012 of 1203 branches covered (84.12%)

2118 of 2195 relevant lines covered (96.49%)

124.3 hits per line

Jobs
ID Job ID Ran Files Coverage
1 792.1 19 Jul 2018 02:57PM UTC 0
15.85
Travis Job 792.1
2 792.2 19 Jul 2018 02:56PM UTC 0
15.85
Travis Job 792.2
3 792.3 19 Jul 2018 02:57PM UTC 0
15.85
Travis Job 792.3
4 792.4 19 Jul 2018 02:57PM UTC 0
15.85
Travis Job 792.4
5 792.5 19 Jul 2018 02:57PM UTC 0
96.49
Travis Job 792.5
Source Files on build 792
  • Tree
  • List 0
  • Changed 18
  • Source Changed 4
  • Coverage Changed 18
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Travis Build #792
  • Pull Request #227
  • PR Base - master (#775)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc