TryGhost / Ghost-Admin / 3995

70%

push

travis-ci

🐛 Koenig - Fixed clicking certain icons in /-menu not creating cards

refs https://github.com/TryGhost/Ghost/issues/9724
- the click event from clicking on the /-menu items continued propagating after the card was initialised which meant it was picked up by the card as a "click off the card" so certain cards such as the Markdown/HTML cards would then remove themselves as if they were deselected with empty content
- changed the icon click handler to use the DOM `onclick` syntax so that the click can be captured immediately rather than waiting for it to bubble up to Ember's global event handler
- updated the /-menu `itemClicked` action to use the now-accessible MouseEvent to stop it propagating any further and triggering unwanted card behaviour

1835 of 2912 branches covered (63.02%)

4198 of 5816 relevant lines covered (72.18%)

47.57 hits per line