• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PulpQE / pulp-smash / 2749
63%

Build:
DEFAULT BRANCH: master
Ran 16 Jul 2018 02:50PM UTC
Jobs 3
Files 14
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2749

push

travis-ci

Ichimonji10
Replace os_is_* functions

The `pulp_smash.utils.os_is_f2{6,7}` functions are not suitable for
inclusion within a top-level toolkit. There's an enormous number of
combinations of system facts that one might want to discover, and having
`os_is_*` functions is a recipe for an explosion in number of functions.
A framework should provide more generalized tools that individual users
can adapt to their needs.

Replace these functions with functions that report information from
`/etc/os-release`. This is more suitable for use within a toolkit: there
is a much more constrained set of values that one may wish to get from
`/etc/os-release`.

These functions are still somewhat susceptible to a surface-area
explosion. If users wish to get more and more information from
`/etc/os-release`, then it would be best to create a function which
returns a dict where the keys and values correspond to the keys and
values in `/etc/os-release`. Thankfully, the new functions which were
just added are forward compatible with such a design. If these happens,
the just-added functions could be rewritten like so:

```python
def get_os_release_id(cfg, pulp_host=None):
    raise DeprecationWarning(...)
    return get_os_release(cfg, pulp_host)['ID']
```

Fix: https://github.com/PulpQE/pulp-smash/issues/1100

613 of 1022 relevant lines covered (59.98%)

1.8 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2749.1 16 Jul 2018 02:52PM UTC 0
59.98
Travis Job 2749.1
2 2749.2 16 Jul 2018 02:50PM UTC 0
59.98
Travis Job 2749.2
3 2749.3 16 Jul 2018 02:51PM UTC 0
59.98
Travis Job 2749.3
Source Files on build 2749
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2749
  • 168d5eed on github
  • Prev Build on master (#2735)
  • Next Build on master (#2753)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc