zalando-incubator / postgres-operator / 1254

24%

push

travis-ci

<a href="https://github.com/zalando-incubator/postgres-operator/commit/<a class=hub.com/zalando-incubator/postgres-operator/commit/e90a01050c68fef2e7e095b4c7b443a25730c25f">e90a01050<a href="https://github.com/zalando-incubator/postgres-operator/commit/e90a01050c68fef2e7e095b4c7b443a25730c25f">&quot;&gt;Switchover must wait for the inner goroutine before it returns. (#343)

* Switchover must wait for the inner goroutine before it returns.

Otherwise, two corner cases may happen:

 - waitForPodLabel writes to the podLabelErr channel that has been
   already closed by the outer routine

 - the outer routine exists and the caller subscribes to the pod
   the inner goroutine has already subscribed to, resulting in panic.

 The previous commit https://github.com/zalando-incubator/postgres-operator/commit/</a><a class="double-link" href="https://github.com/zalando-incubator/postgres-operator/commit/<a class="double-link" href="https://github.com/zalando-incubator/postgres-operator/commit/fe47f9ebeadd54639913296735158b42d17ee012">fe47f9ebe</a>">fe47f9ebe</a><a href="https://github.com/zalando-incubator/postgres-operator/commit/e90a01050c68fef2e7e095b4c7b443a25730c25f">
 that touched that code added the cancellation channel, but didn&#39;t bother
 to actually wait for the goroutine to be cancelled.

 Per report and review from @valer-cara.
 Original issue: https://github.com/zalando-incubator/postgres-operator/issues/342

205 of 4397 relevant lines covered (4.66%)

0.19 hits per line