zalando-incubator / postgres-operator / 1251

5%

master: 24%

Pull #343

travis-ci

Switchover must wait for the inner goroutine before it returns.

Otherwise, two corner cases may happen:

 - waitForPodLabel writes to the podLabelErr channel that has been
   already closed by the outer routine

 - the outer routine exists and the caller subscribes to the pod
   the inner goroutine has already subscribed to, resulting in panic.

 The previous commit https://github.com/zalando-incubator/postgres-operator/commit/fe47f9ebe
 that touched that code added the cancellation channel, but didn't bother
 to actually wait for the goroutine to be cancelled.

 Per report from @valer-cara.
 Original issue: https://github.com/zalando-incubator/postgres-operator/issues/342

23 of 23 new or added lines in 1 file covered. (100.0%)

205 of 4391 relevant lines covered (4.67%)

0.19 hits per line