sphereio / sphere-node-product-csv-sync / 1300

78%

push

travis-ci

<a href="https://github.com/sphereio/sphere-node-product-csv-sync/commit/<a class=hub.com/sphereio/sphere-node-product-csv-sync/commit/0c74fff3059d77dfd360f2918823adb240e3ed91">0c74fff30<a href="https://github.com/sphereio/sphere-node-product-csv-sync/commit/0c74fff3059d77dfd360f2918823adb240e3ed91">&quot;&gt;fix(export): add missing customWherePredicate (#221)

#### Summary
Add missing `customWherePredicate`, remove unnecessary queuing and delete unused `_stringifyQueryString` function.

#### Description
When we migrated to the new JS SDK we forgot to add the `customWherePredicate` as it was used [here](https://github.com/sphereio/sphere-node-product-csv-sync/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/sphereio/sphere-node-product-csv-sync/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/sphereio/sphere-node-product-csv-sync/commit/<a class=hub.com/sphereio/sphere-node-product-csv-sync/commit/dd1c91cad6f53d9a47568052b73bbed12f0fc365">dd1c91cad">dd1c91cad</a><a href="https://github.com/sphereio/sphere-node-product-csv-sync/commit/0c74fff3059d77dfd360f2918823adb240e3ed91">#diff-6bcf5a5c3fede97b90ad47a12b6beaa4L139) to the new implementation [here](https://github.com/sphereio/sphere-node-product-csv-sync/commit/dd1c91cad6f53d9a47568052b73bbed12f0fc365#diff-6bcf5a5c3fede97b90ad47a12b6beaa4R162).

This caused a bug which made the exporter export a lot more products than clients needed. Especially for big customers this would change the export time from under 20 mins to over 6 hours.

Finally, since we are using the JS SDK&#39;s [process method](https://commercetools.github.io/nodejs/sdk/api/sdkClient.html#processrequest-processfn-options) there is no need to use the `createQueueMiddleware` as the method _iterates_ through the requests and does not call them all concurrently. 

resolves #220

#### Todo

- Tests
    - [x] Unit
    - [x] Integration</a>

586 of 828 branches covered (70.77%)

1702 of 2027 relevant lines covered (83.97%)

2052.84 hits per line