10342
99%

Ran 06 Jul 2018 08:31PM UTC

Jobs 1

Files 206

Run time 14s

Badge

Embed ▾

pending completion

Build # 10342

Build Type

push

travis-ci

Committed by

bmw

Commit Message

Do not call IPlugin.prepare() for updaters when running renew (#6167)

interfaces.GenericUpdater and new enhancement interface updater functions get run on every invocation of Certbot with "renew" verb for every lineage. This causes performance problems for users with large configurations, because of plugin plumbing and preparsing happening in prepare() method of installer plugins. This PR moves the responsibility to call prepare() to the plugin (possibly) implementing a new style enhancement interface.

Fixes: #6153

* Do not call IPlugin.prepare() for updaters when running renew

* Check prepare called in tests

* Refine pydoc and make the function name more informative

* Verify the plugin type

Run Details

24890 of 25204 relevant lines covered (98.75%)

0.99 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	10342.3 (TOXENV=cover FYI="this also tests py27")	06 Jul 2018 08:31PM UTC	0	98.75	Travis Job 10342.3

Source Files on build 10342

Detailed source file information is not available for this build.

certbot / certbot / 10342
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10342

certbot / certbot / 10342 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10342

certbot / certbot / 10342
99%

README BADGES
x