979
28%

Ran 06 Jul 2018 10:39AM UTC

Jobs 6

Files 33

Run time 7min

Badge

Embed ▾

pending completion

Build # 979

Build Type

Pull #465

travis-ci

Committed by David Aguilar

Commit Message

core: fix infinite recursion in __getattr__

The intention of `__getattr__` is to return the value from the
internal state.  When using the factory pattern, the instance's
`_state` is never set, so `__getattr__` fails:

        flask_security/core.py:569: in __getattr__
            return getattr(self._state, name, None)
        !!! Recursion detected (same locals & position)

We can make both use cases work by providing a default `_state`
that points to the security local proxy at the class level.
This allows the immediate-constructor `Security(app)` form to
override the class attribute in the instance, as it currently
does, while also allowing `__getattr__` to succeed when using
the factory pattern.

Add tests to exercise both the existing and newly-fixed behaviors.

Related-to: #317
Signed-off-by: David Aguilar <davvid@gmail.com>

Pull Request Pull Request #465:

Run Details

690 of 756 relevant lines covered (91.27%)

16.41 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	979.1 (REQUIREMENTS=lowest)	06 Jul 2018 10:42AM UTC	20	94.07	Travis Job 979.1
2	979.2 (REQUIREMENTS=lowest)	06 Jul 2018 10:39AM UTC	20	94.07	Travis Job 979.2
3	979.3 (REQUIREMENTS=lowest)	06 Jul 2018 10:39AM UTC	20	94.07	Travis Job 979.3
4	979.4 (REQUIREMENTS=release)	06 Jul 2018 10:39AM UTC	20	93.8	Travis Job 979.4
5	979.5 (REQUIREMENTS=release)	06 Jul 2018 10:39AM UTC	20	93.8	Travis Job 979.5
6	979.6 (REQUIREMENTS=release)	06 Jul 2018 10:47AM UTC	20	93.8	Travis Job 979.6

mattupstate / flask-security / 979
28%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 979

mattupstate / flask-security / 979 28%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 979

mattupstate / flask-security / 979
28%

README BADGES
x