nordnet / nordnet-ui-kit / 1695

63%

push

travis-ci

feat(PopupMenu): make PopupMenu accessible (#409)

* feat(popup menu): start making popup menu accessible

Copy over and refactor code from the watchlist search to work for the popup menu.

* feat(popup menu): blur list on esc

* feat(popup menu): fix onblur edge case

The isOpen state wasn't reset, though the menu was visibly closed, if the last list item lost focus.

* feat(popup menu): skip disabled items with arrow navigation

* refactor(popup menu): clean up, api documentation and use functional component over stateful

* feat(popup menu): make isOpen override state

* test(popup menu): update tests to reflect changes

Some tests failed because of the PopupMenuList introduction, and some tests tested functionality
that now moved to PopupMenuItem.

* refactor(popup menu): remove unnecessary focus tracking

* feat(popup menu): add aria attributes

* fix(popup menu): fix refs for React Router Links in popup menu item

* test(popup menu): add missing test cases for focus handling functionality

Port over some test cases from SearchResults and add some other missing ones.

* fix: remove bogus setTimeout

* fix: make disabled elements buttons

* chore: remove stupid comment

* fix: remove unneeded onFocus

* fix: remove new Date and add unmount

* feat(popup menu): make user supply button ID if label is used

289 of 621 branches covered (46.54%)

Branch coverage included in aggregate %.

1599 of 1982 relevant lines covered (80.68%)

15.47 hits per line