12629
83%
master: 87%

Ran 27 Jun 2018 08:10PM UTC

Jobs 1

Files 301

Run time 39s

Badge

Embed ▾

pending completion

Build # 12629

Build Type

push

travis-ci

Committed by

kostja

Commit Message

iproto: fix IPROTO_SERVER_IS_RO key code

IPROTO_SERVER_IS_RO currently has code 0x07 and is defined in the header
key section, which is wrong, because this key is only used in request
body. Let's move it to the body section, where it belongs, and set its
code to 0x29. This shouldn't break anything even if 0x07 is reused in
future, because the two codes belong to different sections and hence are
never parsed in the same function. Worst that can happen is we fail to
bootstrap a node in the cluster if it is running a newer tarantool
version.

While we are at it, let's also add the key name and change its type from
MP_UINT to MP_BOOL.

Fixes commit a8ecd1e122ae ("replication: fix bug with read-only replica
as a bootstrap leader").

Run Details

39584 of 48298 relevant lines covered (81.96%)

896128.77 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	80.62	-0.11%	src/box/xlog.c
1	87.2	0.3%	src/box/vy_run.c
1	87.96	0.46%	src/box/xrow.c
1	97.5	-1.25%	src/histogram.c
1	98.2	0.9%	src/lib/small/test/rb_rand.cc
1	94.71	-0.29%	src/box/wal.c
3	59.59	-0.88%	src/coio.cc
6	84.43	-3.59%	src/coio_task.c

Jobs

ID	Job ID	Ran	Files	Coverage
3	12629.3 (TARGET=coverage)	27 Jun 2018 08:10PM UTC	301	81.96	Travis Job 12629.3

tarantool / tarantool / 12629
83%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12629

tarantool / tarantool / 12629 83% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 12629

tarantool / tarantool / 12629
83%
master: 87%

README BADGES
x