TykTechnologies / tyk / 5205

59%

master: %

Pull #1797

travis-ci

Fix panic caused by URL based versioning

`getVersionFromRequest` do not get in account `NotVersioned` flag, and
UI by default writes `a.VersionDefinition.Location` field, so this
check for version inside url was running for all non versioned APIs.

In case of cloud it was causing panics, because nginx layer maps `slug`
to `listenpath` and actual user URL does not contain listen path, and
can be even smaller (which cause panic). Replaced manual array
operation with `strings.TrimPrefix` which checks array bounds, and
added support for stripping slug from URL too (for cloud case).

8 of 8 new or added lines in 2 files covered. (100.0%)

9206 of 15532 relevant lines covered (59.27%)

1.32 hits per line