zendframework / zend-diactoros / 830

96%

master: 96%

Pull #307

travis-ci

Extract logic for marshaling host and port to dedicated function(s)

ADDS `Zend\Diactoros\getHeaderFromArray(string $name, array $headers,
$default = null)`, for extracting a value from a header array.

DEPRECATES `ServerRequestFactory::getHeader()`, and has it proxy to
`getHeaderFromArray()`.

ADDS `Zend\Diactoros\marshalHostAndPort(array $headers, array $server) :
array`, to allow detecting the host and port from either the request
headers or the SAPI environment.

DEPRECATES `ServerRequestFactory::marshalHostAndPortFromHeaders()`, and
has it proxy to `marshalHostAndPort(). It is no longer used internally.

REMOTES `ServerRequestFactory::marshalHostAndPortFromHeader()` and
`ServerRequestFactory::marshalIpv6HostAndPort()`. Both were private, and
are no longer called within `ServerRequestFactory`; the logic in each is
now embedded in `marshalHostAndPort()`.

97 of 97 new or added lines in 8 files covered. (100.0%)

1226 of 1270 relevant lines covered (96.54%)

42.55 hits per line