TokTok / c-toxcore / 5099

0%

Pull #932

travis-ci

Various minor cleanups in `net_crypto`.

* Consistently use `num_packets_array` to get the packet count in the
  packet buffer.
* Use `const` in more places.
* Typo fix: begginning.
* Rewrite `length < 1` for unsigned int to `length == 0`.
* Limit scope of some loop variables by using for-init-decl.
* Use early return in error paths to reduce indentation and for clarity.
* Use `net_unpack_*` instead of manual `ntohs`.
* Fix an uninitialised stack variable copy.
* Fix a potential null pointer dereference.
* Consistently use `get_crypto_connection`. It was inlined in some
  places. I de-inlined it now.
* Add Loggers to some functions in preparation for adding log statements.

115 of 115 new or added lines in 7 files covered. (100.0%)

4780 of 10682 relevant lines covered (44.75%)

307137.71 hits per line