12549
100%
master: 88%

Ran 19 Jun 2018 09:14AM UTC

Jobs 1

Files 353

Run time 23s

Badge

Embed ▾

pending completion

Build # 12549

Build Type

push

travis-ci

Committed by

kyukhin

Commit Message

sql: remove redundant goto from VDBE prologue

Structure of VDBE prologue:

    0: OP_Init 0 N (address to start) 0 --|
|-> 1: ...                                |
|      ...                                |
|   N: OP_Transaction         <------------
|   N+1: (Constant expressions to be saved in registers)
|      ...
|-- M: OP_Goto 0 1 0

However, last opcode in VDBE program (i.e. OP_Goto) is generated always,
despite the existence of OP_Transaction or constant expressions.
Thus, VDBE program for queries like <SELECT * FROM table;> features
redundant jump. Such useless jump wastes exectuion time (although it is
executed once) and may affect jump prediction.

This patch adds conditional branch for generating jump opcode finishing
VDBE program: it is appended only if we need to start transaction or
code constrant expressions.

Closes #3231

Coverage Stats

62209 of 76601 relevant lines covered (81.21%)

1494046.83 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	12549.3 (TARGET=coverage)	19 Jun 2018 09:14AM UTC	0	81.21	Travis Job 12549.3

Source Files on build 12549

Detailed source file information is not available for this build.

tarantool / tarantool / 12549
100%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12549

tarantool / tarantool / 12549 100% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12549

tarantool / tarantool / 12549
100%
master: 88%

README BADGES
x