12545
81%
master: 87%

Ran 18 Jun 2018 09:11PM UTC

Jobs 1

Files 353

Run time 43s

Badge

Embed ▾

pending completion

Build # 12545

Build Type

push

travis-ci

Committed by

Korablev77

Commit Message

sql: remove redundant goto from VDBE prologue

Structure of VDBE prologue:

    0: OP_Init 0 N (address to start) 0 --|
|-> 1: ...                                |
|      ...                                |
|   N: OP_Transaction         <------------
|   N+1: (Constant expressions to be saved in registers)
|      ...
|-- M: OP_Goto 0 1 0

However, last opcode in VDBE program (i.e. OP_Goto) is generated always,
despite the existence of OP_Transaction or constant expressions.
Thus, VDBE program for queries like <SELECT * FROM table;> features
redundant jump. Such useless jump wastes exectuion time (although it is
executed once) and may affect jump prediction.

This patch adds conditional branch for generating jump opcode finishing
VDBE program: it is appended only if we need to start transaction or
code constrant expressions.

Closes #3231

Run Details

62185 of 76516 relevant lines covered (81.27%)

1471721.33 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	12545.3 (TARGET=coverage)	18 Jun 2018 09:11PM UTC	353	81.27	Travis Job 12545.3

tarantool / tarantool / 12545
81%
master: 87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12545

tarantool / tarantool / 12545 81% master: 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12545

tarantool / tarantool / 12545
81%
master: 87%

README BADGES
x