stripe / stripe-go / 2860

66%

Pull #591

travis-ci

Organize core files alphabetically and into sections

This patch organizes some of library's core files (`stripe.go`,
`params.go`, `iter.go`) alphabetically and into sections. Here are the
key changes:

* Introduces "sections" of codes, these are (in order how they actually
  appear in the file too)::

    ```
    // Public constants
    // Public variables
    // Public types
    // Public functions
    // Private constants
    // Private variables
    // Private types
    // Private functions
    ```

    The premise is that symbols which are intended to be more widely
    used (because they're exported out of the package) are at the top of
    the file for easier access, while unexported symbols are organized
    closer to the bottom.

* Within each section, all symbols are organized alphabetically.
* All type-specific functions (e.g. `func (p *Params) GetParams`) are
  arranged below the type they're attached to, and organized
  alphabetically within their type. Unexported functions are arranged
  below exported functions because that's better, also because lowercase
  letters lexically sort after uppercase letters (`A` > `a`).

And a few other minor opportunistic changes that are somewhat unrelated:

* I dropped the `TotalBackends` constant because it wasn't referenced
  anywhere (this could technically be considered a breaking change, but
  because I don't think there was any sane reason to use it, I don't
  think I'll bump the major version).
* I changed `sleepTime` from a type-specific field to one that's not
  (i.e., `func sleepTime`) because it doesn't depend on any state within
  the struct it was attached to.

I kind of want to get this in because some of these files are turning
into a huge mess and it's a good time because we have no other
outstanding pull requests.

186 of 186 new or added lines in 3 files covered. (100.0%)

3180 of 3831 relevant lines covered (83.01%)

146.4 hits per line