graphql / graphql-js / 3543

98%

push

travis-ci

BREAKING/BUGFIX Strict coercion of scalar types (#1382)

* BREAKING/BUGFIX Strict coercion of scalar types

This no longer accepts incoming variable values in a potentially lossy way, mirroring the existing behavior for literals. This fixes an issue with GraphQL.js being not spec compliant.

This is breaking since servers which used to accept incorrect variable values will now return errors to clients.

Serialization of values is not affected in the same way, since this is not a client-visible behavior.

As a bonus, this adds unique serialization and coercion functions for the ID type, allowing to be more restrictive on numeric types and un-stringable object types, while directly supporting valueOf() methods (ala MongoDB). The changes to how the ID type serializes and coerces data could be potentially breaking.

Fixes #1324

* Updates from review. Simplified ID serialization and added similar logic to string serialization

3452 of 3704 branches covered (93.2%)

10790 of 10928 relevant lines covered (98.74%)

1073.48 hits per line