esl / MongooseIM / 4897

86%

push

travis-ci

Merge pull request #1917 from esl/stabilizing_muc_light_http_api_SUITE

Stabilizing MUC light transaction on MSSQL

Includes:

* Wait for room creation result in muc_light_http_api_SUITE

* remove redundant function and use the same from helper module

* use randomised name for identifiable room

* abort muc light create transaction if more than 1 ID is returned

this may not be needed if READ_COMMITED_SNAPSHOT is ON (OFF by default)

* print stacktrace when mongoose_command crashes

* set READ_COMMITTED_SNAPSHOT ON for MSSQL

This mode used row level locks when running a transaction.
By default this is OFF which uses shared locks. Shared locks tries to by
more intelligent and lock more when they see a trasaction modifies many
different things. This caused a lot of deadlocks around MUC light
transactions.

* document when it's worth to set READ_COMMITED_SNAPSHOT to ON

6 of 6 new or added lines in 2 files covered. (100.0%)

20597 of 28776 relevant lines covered (71.58%)

21875.5 hits per line