home-assistant / home-assistant / 44796
94%

DEFAULT BRANCH: dev
Ran
Jobs 5
Files 402
Run time 14min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
44796

push

travis-ci

balloob 
Samsung TV can't turn off after idle period (#14587)

When Samsung TV is idle for a period of time after issued a command,
subsequent 'turn_off' command won't turn off the TV. The issue is seen
in Samsung models with websocket as discussed in #12302.

== Reproducible Steps
1. Turn on TV (either via HA or directly).
2. Issue some commands e.g. volume ups / downs.
3. Wait for ~1 minute.
4. Issue turn_off command via HA. TV won't turn off.
5. Issue subsequent turn off commands won't turn off TV still.
6. However, issue some other commands e.g. volume ups / downs multiple
times in a row and then turn_off will turn off the TV.

== Root Cause
The underlying websocket connection opened by samsungctl get closed
after some idle time. There was no retry mechanism so issued commands
would intermittently fail but the subsequent one would succeed when
`_remote` get recreated. With `turn_off()`, however, there is an
additional call to `self.get_remote().close()` which indirectly caused
new connection to be created and then closed immediately. This causes the
component to stuck in failure mode when turn_off command is repeatly
issued.

== The Fix
Recreate the connection and retry the command if connection is closed
to avoid silent failures due to connection closed. Also set `_remote`
to None after calling close() to put it in correct state.

This fix eliminates intermittent command failure and failure mode in
turn_off().

35695 of 37973 relevant lines covered (94.0%)

1.88 hits per line

Jobs
ID Job ID Ran Files Coverage
1 44796.1 (TOXENV=lint) 0
Travis Job 44796.1
2 44796.2 (TOXENV=pylint) 0
Travis Job 44796.2
3 44796.3 (TOXENV=typing) 0
Travis Job 44796.3
4 44796.4 (TOXENV=py35) 0
94.0
 Travis Job 44796.4
5 44796.5 (TOXENV=py36) 0
94.0
 Travis Job 44796.5
Source Files on build 44796
Detailed source file information is not available for this build.