theforeman / foreman / 8997

64%

Pull #5616

travis-ci

Fixes #23709 - Fix ajaxRequestAction failure dispatch

The FAILURE action dispatched in ajaxRequestAction is not
aligned with the bookmarks, powerStatus and statistics
reducers:
 - Moving to axios returns Error object instead of a string
 - The payload doesn't contain "id" but "item"

This patch fixes that problem and makes components work
again even when there are errors.

In addition, tests were added and fixed
to avoid regression again.

It seems like when an error occures during fetching the data,
the error object is not passed to ChartBox as a string.

In addition, the action payload is different in FAILURE
ending up with a new ChartBox displaying the error message
while the relevant ChartBox still displays a spinner.

Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

365 of 598 branches covered (61.04%)

5 of 5 new or added lines in 3 files covered. (100.0%)

917 of 1153 relevant lines covered (79.53%)

38.38 hits per line