RestPack / restpack_serializer / 382

99%

Pull #144

travis-ci

Drop protected_attributes_continued development dependency

When the first Active Record fixtures were added to the test suite in
<a class=hub.com/RestPack/restpack_serializer/commit/0ba7f778447454275bc46e035358aeaf56e5e0e5">0ba7f7784<a href="https://github.com/RestPack/restpack_serializer/commit/15747d8566710587a1b4ae93c1b7418115eb412d">, a call to `attr_accessible`
was included in each model.

Later `protected_attributes` was added as a development dependency in
<a class="double-link" href="https://github.com/RestPack/restpack_serializer/commit/c9403c5603a31a0799696258d95eeacda0814628">c9403c560</a><a href="https://github.com/RestPack/restpack_serializer/commit/15747d8566710587a1b4ae93c1b7418115eb412d"> to allow the `attr_accessible`
calls to continue to work on Rails 4.

Later still in </a><a class="double-link" href="https://github.com/RestPack/restpack_serializer/commit/b1a928c2dbcf000d29da055d299379d8822526aa">b1a928c2d</a>, the dependency
was switched to `protected_attributes_continued` as the original
`protected_attributes` gem doesn't support Rails 5.

Now that Rails 5.2 has been released, the test suite is failing because
`protected_attributes_continued` isn't compatible with it.

However, I don't think the `attr_accessible` calls were ever necessary:
if I check out 0ba7f778447454275bc46e035358aeaf56e5e0e5 and remove them,
the test suite still passes. restpack_serializer doesn't perform mass
assignment on those models (or any assignment at all).

726 of 731 relevant lines covered (99.32%)

1.85 hits per line